Add support for borders #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @caendesilva thanks for the PR. I would say we need to have the same api, with the Can you make this adjustments? Thanks and sorry for the delay reviewing your PR. |
Hey! I'll try, I need to learn more about how the other components work so may take some time |
|
no worries, any question let me know. Thanks, Francisco. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Here's my initial work on border support (fixing #177)
I've created the base logic, and think that it would be best if I could get some maintainer help to make sure it gets fully integrated with how the rest of the Termwind framework is supposed to work.
I think since the rendering logic is kinda complex it could make sense to have this as a pseudo-element rather than a style, but that's something that's up to you. I put the heavy logic in an action class to make it more self-contained depending on how you want to handle it. I have not yet added support for colours as I just want to know if I'm on the right track first.